-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang update reorder #1201
Clang update reorder #1201
Conversation
60ca4e2
to
f927e82
Compare
70874bb
to
4245190
Compare
4245190
to
c3896d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, I'll test this on different machines for any compilation issues, bugs and stability.
Removes some go_repository rules for things AGI doesn't actually depend on.
- Add build target darmin_arm64 - Update breakpad to be compatible with
- Remove unused variable
- Remove unnecessary Windows patch
3a63dab
to
f253075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems to be working fine on m1 and linux. I believe we can fix the remaining issues, if there are any, after merging this.
This PR updates a bunch of dependency, adds support for Apple M1 and switches Linux compiler from GCC-9 to Clang-12