Linter integration #1143
Merged
Linter integration #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalcinmelihyasin
force-pushed
the
linter_integration
branch
from
08bbc2c to
3c66572
Compare
yalcinmelihyasin
force-pushed
the
linter_integration
branch
12 times, most recently
from
53d9811 to
965ded1
Compare
yalcinmelihyasin
force-pushed
the
linter_integration
branch
from
d4cbb86 to
a456cd9
Compare
purvisa-at-google-com
approved these changes
Jul 4, 2022
| name = "tests-vulkan-generator", | ||
| tests = [ | ||
| # Run the linting as part of Vulkan generator tests | ||
| "//:lint", # DO NOT REMOVE! |
There was a problem hiding this comment.
Do we need a comment saying do not remove?
There was a problem hiding this comment.
Well, it is very easy to remove a test from bazel and not catch its missing. I just want to ensure that no one comes and says "why this is here" and remove it without thinking the implications. Having it there has no harm.
| TARGETS=$(echo "$TARGETS" | grep -v "_flake8" | grep -v "_mypy" | grep -v "_pylint") | ||
|
|
||
| # Sort the linting targets alphabetically | ||
| TARGETS=$(echo "$TARGETS" | sort -t: -k1,1) |
There was a problem hiding this comment.
Can we factor this common stuff out somehow?
There was a problem hiding this comment.
I was thought of but almost every function there is a singular presubmit case. So the benefit of splitting it have not justified break the pattern for me. Instead I put them in a way to make the process clearer for both case.
tools/build/python/lint_flake8.py
Outdated
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| flake8_cli.main(sys.argv[1:]) |
purvisa-at-google-com
approved these changes
Jul 4, 2022
purvisa-at-google-com
approved these changes
Jul 4, 2022
rosasco-wk
pushed a commit
to rosasco-wk/agi
that referenced
this pull request
Sep 2, 2022
Add flake8, autopep8 and mypy to our build pipeline and fix the errors from new linters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Autopep8, Flake8 and mypy to our build system.