Handle malformed dumpsys package output. #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuetschard
requested review from
yalcinmelihyasin,
ttanatb,
sonakshisaxena1 and
purvisa-at-google-com
ttanatb
reviewed
Apr 20, 2022
ttanatb
approved these changes
Apr 20, 2022
Some devices produce malformed dumpsys package output, adding in extra newlines. This change handles a specific version of how this extra whitespace breaks the parser. Fixes google#1077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices produce malformed
dumpsys packageoutput, adding in extra newlines. This change handles a specific version of how this extra whitespace breaks the parser.Parsing the output of
dumpsys packageis not really a good way to do this. Fixing this in a better way is tracked in http://b/229287771Fixes #1077