Implement VK_KHR_depth_stencil_resolve #1066
Conversation
gapis/api/vulkan/state_rebuilder.go
Outdated
| dsrAttachmentRef := NewVkAttachmentReference2ᶜᵖ(sb.MustAllocReadData( | ||
| NewVkAttachmentReference2( | ||
| VkStructureType_VK_STRUCTURE_TYPE_ATTACHMENT_REFERENCE_2, | ||
| NewVoidᶜᵖ(memory.Nullptr), |
There was a problem hiding this comment.
AttachmentReference2 here can originally have pNext that we are missing currently.
There was a problem hiding this comment.
Done, please check this. Test appears to confirm it is correct.
| StencilResolveMode: ext.stencilResolveMode, | ||
| ) | ||
| attachment := ext.pDepthStencilResolveAttachment[0] | ||
| description.DepthStencilResolve.DepthStencilResolveAttachment = AttachmentReference( |
There was a problem hiding this comment.
We are missing pNext handling here.
There was a problem hiding this comment.
@yalcinmelihyasin, just to be clear, the other AttachmentReference() usages on lines 442, 453, 465 and 476 also need 'pNext' handling, yes?
There was a problem hiding this comment.
Yes. with the new PR merging, we are able to do this now.
|
There are some minor comments about adding KHR at the end but I believe that this PR showed a fundamental flaw in our API files in regards to pNext handling. We handle pNext inline in the code without proper modularization. Therefore, the new sub structures in Vulkan e.g VkAttachmentReference2 that can be included in many places now is pain to handle. I would like to hold this PR a bit and talk about how we can restructure this. |
mark-lunarg
force-pushed
the
markl-vk-khr-depth-stencil-resolve
branch
from
dc6a016 to
18daeb7
Compare
* Implement VK_KHR_depth_stencil_resolve * Add extension api file * Address review feedback
Tested with
vulkan_test_applications::depth_stencil_resolve.apk.