Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --times with current Android toolbox #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix --times with current Android toolbox #39

wants to merge 1 commit into from

Conversation

mydongistiny
Copy link

When trying to use --times to push files back to a device it fails with the error:

touch: bad '20190519.083235'
INFO:root:Total: 23412 KB/s (1256329659 bytes in 52.402s)
Traceback (most recent call last):
  File "./adb-sync", line 883, in <module>
    main()
  File "./adb-sync", line 877, in main
    syncer.PerformCopies()
  File "./adb-sync", line 646, in PerformCopies
    self.dst_fs[i].utime(dst_name, (s.st_atime, s.st_mtime))
  File "./adb-sync", line 312, in utime
    raise OSError('touch failed')
OSError: touch failed

because of the current versions of toolbox used on Android devices. So this change fixes the format.

@mydongistiny
Fix --times with current Android toolbox
e9a6d8f 
When trying to use --times to push back to a device
it fails because of the current versions of toolbox
used on Android devices.

Signed-off-by: mydongistiny <[email protected]>
@lingnand
Copy link

Just encountered this and implemented the exact same fix myself. Could we get this merged in so ppl don't waste effort again?

@rubaboo
Copy link

rubaboo commented Dec 5, 2019

Merge please!

Razerban added a commit to Razerban/adb-sync that referenced this pull request Dec 16, 2019
@Razerban
Applied changed present in google#39
d622fc1
aviallon pushed a commit to aviallon/adb-sync that referenced this pull request Jun 22, 2020
@lingnand @aviallon
fix touch timestamp; duplicate of google#39
ecee7fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydongistiny @lingnand @rubaboo