[Pager] Fix PagerState restoration #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbutcher
reviewed
May 17, 2021
There's no need to store the page offset as it could technically be out of bounds (example: if the state was stored during an animation). Fixes #417
chrisbanes
force-pushed
the
cb/pager-restore
branch
from
bc81ab8 to
50142f9
Compare
nickbutcher
approved these changes
May 17, 2021
jossiwolf
pushed a commit
to jossiwolf/accompanist
that referenced
this pull request
Aug 1, 2021
There's no need to store the page offset as it could technically be out of bounds (example: if the state was stored during an animation). Fixes google#417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to store the page offset as it could technically be out of bounds (example: if the state was stored during an animation).
Fixes #417