Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwipeRefresh] Make scrollable requirements clearer in docs #407

Merged
merged 4 commits into from
May 12, 2021

Conversation

chrisbanes
Copy link
Contributor

Fixes #404

@chrisbanes chrisbanes requested a review from ricknout May 12, 2021 16:27
@google-cla google-cla bot added the cla: yes label May 12, 2021
@chrisbanes chrisbanes enabled auto-merge (squash) May 12, 2021 16:28
@chrisbanes chrisbanes disabled auto-merge May 12, 2021 17:29
@chrisbanes chrisbanes merged commit c0ab995 into main May 12, 2021
@chrisbanes chrisbanes deleted the cb/swiperefresh-scrollable-doc branch May 12, 2021 17:30
@chrisbanes chrisbanes added this to the v0.10.0 milestone May 18, 2021
jossiwolf pushed a commit to jossiwolf/accompanist that referenced this pull request Aug 1, 2021
* Improve SwipeRefresh kdoc

Added some info about scrollable content

* Add SwipeRefresh scrollable para to guide

* Fix spotless

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwipeRefresh does not work with a child of type Column()
2 participants