[Pager] Skip intermediate pages during long scroll #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiny micro optimization
nickbutcher
reviewed
Apr 29, 2021
nickbutcher
reviewed
Apr 29, 2021
Co-authored-by: Nick Butcher <[email protected]>
nickbutcher
reviewed
Apr 29, 2021
Co-authored-by: Nick Butcher <[email protected]>
nickbutcher
reviewed
Apr 29, 2021
nickbutcher
reviewed
Apr 29, 2021
nickbutcher
reviewed
Apr 29, 2021
nickbutcher
reviewed
Apr 29, 2021
nickbutcher
reviewed
Apr 29, 2021
nickbutcher
reviewed
Apr 29, 2021
nickbutcher
approved these changes
Apr 29, 2021
# Conflicts: # pager/api/pager.api
Syer10
pushed a commit
to Syer10/accompanist
that referenced
this pull request
May 4, 2021
* Migrate Pager layout info to PagerState * Migrate currentLayoutPage * Fix items flashing in * Start implementing skipped scrolling * Fix tests compile * Tidy up animation functions * Working skipping animateScrollToPage() * Doc fixes * Turn off DebugLog * Tidy up infinite constraints test * Tidy up VerticalPagerTest * Increase tolerance for VerticalPagerTest * Re-add `pageOffset` to [animate]scrollToPage (cherry picked from commit 2ba01f9) # Conflicts: # pager/api/current.api # pager/src/main/java/com/google/accompanist/pager/Pager.kt # pager/src/main/java/com/google/accompanist/pager/PagerState.kt # sample/src/main/java/com/google/accompanist/sample/pager/HorizontalPagerBasicSample.kt # sample/src/main/java/com/google/accompanist/sample/pager/HorizontalPagerTransitionSample.kt # sample/src/main/java/com/google/accompanist/sample/pager/HorizontalPagerWithIndicatorSample.kt # sample/src/main/java/com/google/accompanist/sample/pager/VerticalPagerBasicSample.kt # sample/src/main/java/com/google/accompanist/sample/pager/VerticalPagerWithIndicatorSample.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking API changes:
offscreenLimithas now moved toPagerStateFixes #368