[Insets] Fix attach state change listener not being removed #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were accidentally adding a new attach listener every time, which meant that the one being removed wasn't actually attached. Fixes #364
chrisbanes
changed the title
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this pull request
Apr 26, 2021
Bug: 179787782 Test: Existing tests, run on device Relnote: "Updated Compose Material catalog insets implementation from: google/accompanist#365." Change-Id: I25dc3d73bdf3245036a6299efe11f9c7a2de14df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally adding a new attach listener every time, which meant that the one being removed wasn't actually attached.
Fixes #364