[SwipeRefresh] Make indicator more flexible #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful when needing to inset the indicator in from the start edge.
This allows us to support alternative style indicators, such as the bundled 'glow' indicator sample.
It now lives in SwipeRefreshIndicator
It doesn't really belong there.
ricknout
approved these changes
Apr 20, 2021
swiperefresh/src/main/java/com/google/accompanist/swiperefresh/SwipeRefreshIndicator.kt
Show resolved
Hide resolved
swiperefresh/src/main/java/com/google/accompanist/swiperefresh/SwipeRefresh.kt
Show resolved
Hide resolved
nickbutcher
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few improvements here:
SwipeRefresh()to tweak the positioning and padding of the indicator. This allows apps which usecontentPaddingonLazyRowetc, to get the indicator to match.SwipeRefreshIndicator()itself. This allows devs to provide any type of indicator they want. The update custom indiciator sample shows a fade-in gradient instead demo.SwipeRefreshState. It's never really been part of the state, and was only there for convenience.