Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update currentPager after calling scrollToPage() #338

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Update currentPager after calling scrollToPage() #338

merged 1 commit into from
Apr 14, 2021

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Apr 14, 2021 •
edited
Loading

We were missing a snapToNearestPage()

Fixes #337

@chrisbanes
Update currentPager after calling scrollToPage()
8687832 
We were missing a snapToPage().

Fixes #337
@google-cla google-cla bot added the cla: yes label Apr 14, 2021
@chrisbanes chrisbanes requested a review from manuelvicnt April 14, 2021 08:27
@chrisbanes chrisbanes enabled auto-merge (squash) April 14, 2021 08:27
@chrisbanes chrisbanes merged commit 6717b37 into main Apr 14, 2021
@chrisbanes chrisbanes deleted the cb/pager-scrollto branch April 14, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelvicnt manuelvicnt manuelvicnt approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pager] PagerState currentPage does not change after calling scrollToPage(...)
2 participants
@chrisbanes @manuelvicnt