Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SwipeRefresh] Update doc page #334

Merged
merged 1 commit into from
Apr 13, 2021
Merged

[SwipeRefresh] Update doc page #334

merged 1 commit into from
Apr 13, 2021

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Apr 13, 2021 •
edited
Loading

Also renamed SwipeRefreshCustomSample to SwipeRefreshTweakedIndicatorSample, and added a new SwipeRefreshCustomIndicatorSample.

Thanks to @ricknout for providing some demo videos!

Closes #324

@chrisbanes
[SwipeRefresh] Update doc page
30158f4 
Thanks to @ricknout for providing some demo videos!
@google-cla google-cla bot added the cla: yes label Apr 13, 2021
ricknout
ricknout reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@ricknout ricknout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but the videos don't seem to be working when I view the markdown on GitHub on the cb/swiperefresh branch 🤔

@chrisbanes
Copy link
Contributor Author

Changes LGTM, but the videos don't seem to be working when I view the markdown on GitHub on the cb/swiperefresh branch 🤔

I'm not surprised, this is using all sorts of markdown extensions which GitHub doesn't support.

I should try and figure out a way to build the site and deploy it somewhere, similar to what we do for snapshots.

ricknout
ricknout approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@ricknout ricknout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, guessing it works fine on the docs page so approving

@chrisbanes chrisbanes enabled auto-merge (squash) April 13, 2021 17:21
@chrisbanes chrisbanes disabled auto-merge April 13, 2021 17:27
@chrisbanes chrisbanes merged commit 272ab53 into main Apr 13, 2021
@chrisbanes chrisbanes deleted the cb/swiperefresh-docs branch April 13, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricknout ricknout ricknout approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SwipeRefresh] Add docs page
2 participants
@chrisbanes @ricknout