[Image] LoadPainter #321
Merged
[Image] LoadPainter #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andkulikov
reviewed
Apr 12, 2021
imageloading-core/src/main/java/com/google/accompanist/imageloading/Image.kt
Outdated
Show resolved
Hide resolved
imageloading-core/src/main/java/com/google/accompanist/imageloading/ImageState.kt
Outdated
Show resolved
Hide resolved
chrisbanes
force-pushed
the
cb/image-painter
branch
from
fac2897 to
64df60e
Compare
andkulikov
reviewed
Apr 12, 2021
chrisbanes
force-pushed
the
cb/image-painter
branch
from
64df60e to
c1e6919
Compare
Allows us to tidy up the handling of the loader parameter, and it's stability.
They now behave the same as previous versions of the library. This fixes the failing tests.
Not sure why it's required now, but this is all deprecated code /shruggie.
andkulikov
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the image loading libraries again, this time to a
Painterinstance, retrieved throughrememberLoadPainter(), This allows us to remove our layout composable, and rely solely on Compose Foundation'sImage()composable.Tasks
ReplaceWiths