[SystemUiController] API fixes #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no real need for a composition local to store the SystemUiController. They're infrequently enough that simply using rememberAndroidSystemUiController() as necessary works.
nickbutcher
approved these changes
Apr 9, 2021
It's now rememberSystemUiController. Also hid the AndroidSystemUiController class as there's no need for it to be public.
chrisbanes
changed the title
andkulikov
reviewed
Apr 9, 2021
...emuicontroller/src/main/java/com/google/accompanist/systemuicontroller/SystemUiController.kt
Outdated
Show resolved
Hide resolved
andkulikov
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local SystemUiController. There's no real need for a composition local to store theSystemUiController. They're infrequently enough that simply usingrememberSystemUiController()as necessary works.AndroidSystemUiControllerclass.rememberAndroidSystemUiController()torememberSystemUiController()