Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SystemUiController] Add Window.isNavigationBarContrastEnforced APIs #318

Merged
merged 5 commits into from
Apr 9, 2021

Conversation

joharei
Copy link
Contributor

@joharei joharei commented Apr 9, 2021

Fixes #317.

I'm not sure about the naming of the APIs.

Also, is there is a better way to test this on different system gesture modes?

@google-cla
Copy link

google-cla bot commented Apr 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 9, 2021
@joharei joharei force-pushed the contrast_enforced branch from a1fc18d to 7317d5d Compare April 9, 2021 09:43
@google-cla
Copy link

google-cla bot commented Apr 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@joharei
Copy link
Contributor Author

joharei commented Apr 9, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 9, 2021
Copy link
Contributor

@chrisbanes chrisbanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 small nits

@chrisbanes chrisbanes enabled auto-merge (squash) April 9, 2021 10:17
auto-merge was automatically disabled April 9, 2021 11:39

Head branch was pushed to by a user without write access

@chrisbanes chrisbanes enabled auto-merge (squash) April 9, 2021 12:06
@chrisbanes chrisbanes merged commit 97bd7d4 into google:main Apr 9, 2021
@joharei joharei deleted the contrast_enforced branch April 9, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Idea] [SystemUiController] Support Window.isNavigationBarContrastEnforced
2 participants