Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose animation spec in animateScrollToPage() #312

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Expose animation spec in animateScrollToPage() #312

merged 1 commit into from
Apr 7, 2021

Conversation

ln-12
Copy link
Contributor

@ln-12 ln-12 commented Apr 7, 2021

This change exposes the animationSpec parameter from PagerState.animateToPage() (which is private) to PagerState.animateScrollToPage() so that the animation can be changed as needed.

@google-cla google-cla bot added the cla: yes label Apr 7, 2021
Copy link
Contributor

@chrisbanes chrisbanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@chrisbanes chrisbanes merged commit 79bd525 into google:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants