Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pager] Fix reverseLayout = true #303

Merged
merged 1 commit into from
Apr 1, 2021
Merged

[Pager] Fix reverseLayout = true #303

merged 1 commit into from
Apr 1, 2021

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Apr 1, 2021

Pager was using placeRelative() which only honours the layout direction and not the reverseLayout value.

Fixes #297

@google-cla google-cla bot added the cla: yes label Apr 1, 2021
@chrisbanes chrisbanes requested a review from nickbutcher April 1, 2021 10:40
Base automatically changed from cb/pager-infinite to main April 1, 2021 10:59
Pager was using placeRelative() which only honours the layout
direction and not the `reverseLayout` value.

Fixes #297
@chrisbanes chrisbanes merged commit e159d91 into main Apr 1, 2021
@chrisbanes chrisbanes deleted the cb/pager-reverse branch April 1, 2021 17:09
@danieldaeschle
Copy link

is it possible to use the changes immediately or when will a new release be created?

@chrisbanes
Copy link
Contributor Author

chrisbanes commented Apr 1, 2021

is it possible to use the changes immediately or when will a new release be created?

Yep: https://google.github.io/accompanist/using-snapshot-version/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pager] reverseLayout reverses touch gestured but scroll layout doesn't change
3 participants