Move away from using WithConstraints
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamp
suggested changes
Jun 17, 2020
adamp
suggested changes
Jun 17, 2020
|
|
||
| onCommit(result) { | ||
| // Execute the onRequestCompleted callback if we have a new result | ||
| result?.also { onRequestCompleted(it) } |
There was a problem hiding this comment.
Consider running this in the same block as the result = it in the CoilRequestActor callback instead of returning to composition with an onCommit; store the received callback in a MutableState in case it changes and call it from the state value
There was a problem hiding this comment.
Done, I'm liking where this has landed 👍. Thanks for the help!
manuelvicnt
reviewed
Jun 18, 2020
| val requestWidth = constraints.requestWidth.value | ||
| val requestHeight = constraints.requestHeight.value | ||
| var result by state<RequestResult?> { null } | ||
| val callback = mutableStateOf(onRequestCompleted) |
There was a problem hiding this comment.
Why is this a state? this value is never changed and onRequestCompleted is defined as a param
There was a problem hiding this comment.
This was something @adamp mentioned in #30 (comment)
added 6 commits
June 22, 2020 18:03
WithConstraints is not suitable for how we're using it, so we're moving to Modifier.onSizeChanged(). This required some changes to how CoilImage is implemented. While here we now use the new launchInComposition() function.
Due to using the wrong key parameter to the outer `remember`. Also fixed the state which holds the current callback.
chrisbanes
commented
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithConstraintsis not suitable for how we're using it, so we're moving toModifier.onSizeChanged()(which is based onModifier.onPositioned). This required some changes to how CoilImage is implemented. While here, I also migrated us to the newlaunchInComposition()to launch our Coil request.