Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose progress of animated insets #242

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Expose progress of animated insets #242

merged 4 commits into from
Mar 16, 2021

Conversation

chrisbanes
Copy link
Contributor

This PRs refactors the Insets class so it now stores:

  • Layout insets
  • Animated insets
  • Animated progress fraction

The types of properties have changed slightly (so technically API breaking), but the actual typical usage is exactly the same: LocalWindowInsets.statusBars.top.

Fixes #227

@chrisbanes chrisbanes enabled auto-merge (squash) March 16, 2021 09:00
Copy link
Collaborator

@nickbutcher nickbutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a possible idea about improving encapsulation but LGTM.

@chrisbanes chrisbanes merged commit 255b9dd into main Mar 16, 2021
@chrisbanes chrisbanes deleted the cb/animated-insets branch March 16, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Insets] Expose progress of animated insets
2 participants