[Pager] Migrate to Modifier.scrollable #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/pager-scrollable
branch
from
d28be2c to
c2b73fd
Compare
chrisbanes
force-pushed
the
cb/pager-scrollable
branch
from
c2b73fd to
282181a
Compare
chrisbanes
force-pushed
the
cb/pager-scrollable
branch
from
282181a to
eeb7513
Compare
chrisbanes
force-pushed
the
cb/pager-scrollable
branch
2 times, most recently
from
a5e8bf6 to
836f30e
Compare
chrisbanes
changed the title
nickbutcher
reviewed
Mar 16, 2021
nickbutcher
approved these changes
Mar 16, 2021
Our test is still disabled because we need to make sure we snap to the correct page after an a11y scroll. Most a11y services will just scroll enough so that the item is in view port, which isn't how Pager works.
This allows us to remove our workaround for https://issuetracker.google.com/182893298
We also speed up the snapping animation via a stiffer spring
chrisbanes
force-pushed
the
cb/pager-scrollable
branch
from
c55df48 to
d42994e
Compare
matvei-g
reviewed
Mar 17, 2021
| @IntRange(from = 1) offscreenLimit: Int = 1, | ||
| content: @Composable PagerScope.(page: Int) -> Unit | ||
| decayAnimationSpec: DecayAnimationSpec<Float> = defaultDecayAnimationSpec(), | ||
| snapAnimationSpec: AnimationSpec<Float> = spring(stiffness = SnapSpringStiffness), |
There was a problem hiding this comment.
Here's is an idea: since your internal PagerState.fling uses only public API available (if not, it's still a good idea :) ) what you can do here is to replace two animation specs with one FlingBehaviour, e.g.
object PagerDefaults {
@Composable
fun defaultPagerFlingConfig(state: PagerState, decayAnimationSpec: DecayAnimationSpec<Float>, snapAnimationSpec: AnimationSpec<Float>): FlingConfig { ... }
}
Or similar, then you can just open the whole flingbehaviour for overriding (make FlingBehaviour a param in HorizontalPager), so people can:
- Use default behavior by providing nothing
- Use default with tweaked params
- Use their own sophisticated or slightly different fling behaviour by providing their own instance.
- The API for customization will be consistent with LazyColumn and friends.
What do you think?
There was a problem hiding this comment.
Yeah I like it, I'll follow up after #254
| val density = LocalDensity.current | ||
| val decay = remember(density) { splineBasedDecay<Float>(density) } | ||
| val isRtl = LocalLayoutDirection.current == LayoutDirection.Rtl | ||
| val reverseDirection = if (isRtl) !reverseLayout else reverseLayout |
There was a problem hiding this comment.
If you do if (isRtl) reverseLayout else !reverseLayout to "reverse the reverse", do you still need the shenanigans with minuses in the rest of the logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247