New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation Material] Add null check for retainedEntry in BackHandler #1728

Closed

Vulama wants to merge 1 commit into google:compose-1.5 from Vulama:compose-1.5

Vulama commented Nov 20, 2023

BackHandler sometimes crashes the application with the NullPointerException.
Log from the FirebaseCrashlytics:

Fatal Exception: java.lang.NullPointerException:
       at com.google.accompanist.navigation.material.BottomSheetNavigator$sheetContent$1$2.invoke(BottomSheetNavigator.kt:224)
       at com.google.accompanist.navigation.material.BottomSheetNavigator$sheetContent$1$2.invoke(BottomSheetNavigator.kt:223)

This seems to be a random issue on low-end devices.

This issue was noticed using com.google.accompanist:accompanist-navigation-material:0.32.0 on a large-scale application.


          [Navigation Material] Add null check for retainedEntry in BackHandler

d59d669

bentrengrove requested a review from jossiwolf

November 23, 2023 03:35

Collaborator

bentrengrove commented Dec 20, 2023

Thanks for the fix! We have fixed this in a different way in #1736 so I will close this one out.

bentrengrove closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet