-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebView] ✨ Expose the postUrl function via the WebView Composable #1677
[WebView] ✨ Expose the postUrl function via the WebView Composable #1677
Conversation
Thanks for this contribution, it's looking good! We would also need a test please to be able to merge this |
Hey @bentrengrove, I totally forgot about the test! That's my bad. It should be added now so feel free to check and come back to me with other changes if required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution
It seems like the build failed for some reason. I'm not too sure on why that is however. I can take a look at the code if required 🤔 |
It's running in explicit API mode so you probably just have to add |
It seems as though the lines don't reference anything specific on my side... You can check the lines in the PR but 332, 577 and 700 don't point to anything where I could add the I've tried running the build as configured in the github actions on my side and it works just fine so I'm wondering if I'm missing a config that you may have locally 🤔 I also tried adding the explicit API mode locally but this seems to want keywords in many more places that what the build currently reports. All help on this issue would be appreciated since I'd like to get this added soon ^^ @bentrengrove, could you try to re-run the job and if it fails again, I'll try to see what's going on on my side |
Head branch was pushed to by a user without write access
c6b21c5
to
d7e61b6
Compare
Adds the postUrl function to the WebView
Fixes #1612