[Permissions] MutableMultiplePermissionsState.shouldShowRationale returns true despite some permissions being Denied(shouldShowRationale=false)
#1781
Assignees
Labels
stale
Stale issues which are marked for closure
Comments
|
That does make sense. PR's welcome! |
FelixZY
added a commit
to FelixZY/accompanist
that referenced
this issue
Jul 12, 2024
…`MutableMultiplePermissionsState.shouldShowRationale`
`launchMultiplePermissionRequest` is typically called when
`shouldShowRationale` returns true. However, what may not be as obvious
is that `launchMultiplePermissionRequest` appears to result in a noop if
one or more permissions in `MutableMultiplePermissionsState` are
`Denied(shouldShowRationale=false)`. This caused issues for us in some
code similar to this:
```kotlin
val permissions =
rememberMultiplePermissionsState(
listOf(
ACCESS_FINE_LOCATION,
ACCESS_BACKGROUND_LOCATION,
)
)
when {
// Granted
permissions.allPermissionsGranted -> /* ... */,
// Denied, but I can ask the user
permissions.shouldShowRationale ->
// UNEXPECTED: Does not trigger!
permissions.launchMultiplePermissionRequest()
// Denied and I may not ask the user.
else -> /* ... */
}
```
The fix would seem to be to additionally make sure that there are no
permissions with the `Denied(shouldShowRationale=false)` status before
returning a truthy value from `shouldShowRationale`.
|
I'm also having this issue |
|
However I have issue with this in which shouldShowRationale is never being trigger even I already click don't allow. Check report bugs I have made. |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
@bentrengrove as far as I know this has not yet been resolved? Could you please reopen? |
FelixZY
added a commit
to FelixZY/accompanist
that referenced
this issue
Nov 25, 2024
…`MutableMultiplePermissionsState.shouldShowRationale`
`launchMultiplePermissionRequest` is typically called when
`shouldShowRationale` returns true. However, what may not be as obvious
is that `launchMultiplePermissionRequest` appears to result in a noop if
one or more permissions in `MutableMultiplePermissionsState` are
`Denied(shouldShowRationale=false)`. This caused issues for us in some
code similar to this:
```kotlin
val permissions =
rememberMultiplePermissionsState(
listOf(
ACCESS_FINE_LOCATION,
ACCESS_BACKGROUND_LOCATION,
)
)
when {
// Granted
permissions.allPermissionsGranted -> /* ... */,
// Denied, but I can ask the user
permissions.shouldShowRationale ->
// UNEXPECTED: Does not trigger!
permissions.launchMultiplePermissionRequest()
// Denied and I may not ask the user.
else -> /* ... */
}
```
The fix would seem to be to additionally make sure that there are no
permissions with the `Denied(shouldShowRationale=false)` status before
returning a truthy value from `shouldShowRationale`.
bentrengrove
added a commit
that referenced
this issue
Nov 25, 2024
[Permissions] fix(gh-1781): check for `Denied(shouldShowRationale=false)` in `MutableMultiplePermissionsState.shouldShowRationale`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The current implementation of
MutableMultiplePermissionsState.shouldShowRationaledoes not consider cases where one or more permissions areDenied(shouldShowRationale=false). This causes issues in statements such asThe issue is located at
accompanist/permissions/src/main/java/com/google/accompanist/permissions/MutableMultiplePermissionsState.kt
Line 130 in 57907e1
Suggested fix:
override val shouldShowRationale: Boolean by derivedStateOf { - permissions.any { it.status.shouldShowRationale } + permissions.any { it.status.shouldShowRationale } && permissions.none { !it.status.isGranted && !it.status.shouldShowRationale } }The text was updated successfully, but these errors were encountered: