Skip to content

Commit

Permalink
Use Google Storage symbol server instead of symbols.zip
Browse files Browse the repository at this point in the history
Previously I was creating an etwsymbols*.zip file to hold the UIforETW
PDBs in case debugging or profiling was needed. That works, but it is
messy and inelegant, and creating an actual symbol server - publicly
visible - is quite easy.

The new symbol server path is:
https://randomascii-symbols.commondatastorage.googleapis.com
  • Loading branch information
randomascii committed Mar 14, 2020
1 parent 5d1aff1 commit 6cdb87f
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 8 deletions.
24 changes: 17 additions & 7 deletions package_etw.bat
Original file line number Diff line number Diff line change
Expand Up @@ -159,26 +159,36 @@ powershell ..\GitHub-Source-Indexer\github-sourceindexer.ps1 -symbolsFolder etws
@echo %temp%\srcsrv\pdbstr -r -p:etwsymbols\UIforETWStatic_devrel32.pdb -s:srcsrv
:NoSourceIndexing

@rem Put the ETW symbols in symbol server format and .zip that.
@rem First, add them to a local symbol server directory
@rem Copy the critical PE files to the symbol server as well, to demonstrate best practices.
copy etwpackage\bin\UIforETW*.exe etwsymbols

@rem Add the PE and PDB files to a local symbol server directory, to get the
@rem required directory structure:
if exist etwsymserver rmdir /s/q etwsymserver
"c:\Program Files (x86)\Windows Kits\10\Debuggers\x64\symstore.exe" add /r /f etwsymbols /s etwsymserver /t uiforetw
@rem Delete the excess files.
rmdir etwsymserver\000Admin /s/q
del etwsymserver\pingme.txt
del etwsymserver\refs.ptr /s

del *.zip 2>nul
call python make_zip_file.py etwpackage.zip etwpackage
@echo on
cd etwsymserver
call python ..\make_zip_file.py ..\etwsymbols.zip .
@rem Upload to the randomascii-symbols public symbol server.
@echo Ready to upload the symbols?
@pause
call python c:\src\depot_tools\gsutil.py cp -Z -R . gs://randomascii-symbols
cd ..
@echo on

@rem Make the redistributable .zip file
del *.zip 2>nul
call python make_zip_file.py etwpackage.zip etwpackage
@echo on

@rem Rename to the current version.
call python rename_to_version.py UIforETW\Version.h
@echo on

@echo Now upload the new etwpackage*.zip and etwsymbols*.zip
@echo Now upload the new etwpackage*.zip
@echo But make sure that the PersistedPresets section from startup10.wpaProfile
@echo been deleted to avoid shipping modified presets and bloating the file.
@echo After releasing a version with an updated version number be sure to trigger
Expand Down
1 change: 0 additions & 1 deletion rename_to_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@
version = line[len(prefix) : len(prefix) + 4]
print 'Renaming zip files to version "%s"' % version
os.rename('etwpackage.zip', 'etwpackage%s.zip' % version)
os.rename('etwsymbols.zip', 'etwsymbols%s.zip' % version)
sys.exit(0)
assert(0)

0 comments on commit 6cdb87f

Please sign in to comment.