Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GULObjectSwizzler: allow to disable generated class dispose calls. #66

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

asafkorem
Copy link
Contributor

Allow to disable generated class dispose calls explicitly, and not only when Zombies instrument is enabled.

That is, to support disabling the dispose calls in special cases which are not Zombie related, for examples: firebase/firebase-ios-sdk#9083, as suggested here.

@asafkorem
Copy link
Contributor Author

@paulb777 @ncooke3 @maksymmalyhin tagging you guys because you were involved on the latest change on this class.

IMO this is highly important because the NSZombieEnabled variable workaround is being used from Detox, which is the end-to-end testing framework for many React Native applications. I'm afraid that using this flag may cause other side effects, like unnecessary memory consumptions or ignoring other memory issues.

I think that if we're using such workaround, at least let's have it isolated as possible.

@asafkorem asafkorem force-pushed the feature/dispose-disabled branch from 6c79921 to 0637cfa Compare January 5, 2022 13:37
@ryanwilson
Copy link
Member

Thanks for the contribution! I'm good with this change. It's possible we may have to alter this in the future if we see too many reports of leaks or issues related to the flag, but we'll merge it shortly after CI passes.

@paulb777 paulb777 merged commit e85afdc into google:main Jan 6, 2022
@asafkorem asafkorem deleted the feature/dispose-disabled branch January 6, 2022 19:17
@asafkorem
Copy link
Contributor Author

Thanks guys @paulb777 @ryanwilson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants