Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Refactor privacy manifests to address #150 #155

Merged
merged 4 commits into from
May 8, 2024
Merged

[Infra] Refactor privacy manifests to address #150 #155

merged 4 commits into from
May 8, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 8, 2024 •
edited
Loading

With this PR, the privacy manifest approach is as follows:

  • [changed] SwiftPM library targets have corresponding, unique privacy manifests
  • [unchanged] CocoaPods subspaces share dependency on a common, aggregated privacy manifest

@google-oss-bot
Copy link

google-oss-bot commented May 8, 2024 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (73bc572) and merge commit (b521c49).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/21rIFLfEmi.html

paulb777
paulb777 approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (the catalyst tests have always failed since GHA moved to Xcode 15)

andrewheard
andrewheard approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nick! The GoogleUtilitiesPrivacy cleanup is nice too.

@ncooke3 ncooke3 merged commit 2bc69a0 into main May 8, 2024
19 of 20 checks passed
@ncooke3 ncooke3 deleted the nc/pm-refactor branch May 8, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 Awaiting requested review from paulb777

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard