Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GoogleUtilities] Add privacy manifest for SPM / CocoaPods #144

Merged
merged 11 commits into from
Feb 16, 2024
Merged

[GoogleUtilities] Add privacy manifest for SPM / CocoaPods #144

merged 11 commits into from
Feb 16, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Feb 16, 2024 •
edited
Loading

Fixes #128

cc: @mdmathias

@ncooke3 ncooke3 mentioned this pull request Feb 16, 2024
Merged
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

No changes between base commit (d89bc7c) and merge commit (d9925fa).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/O3AuTUp1AJ.html

@ncooke3 ncooke3 merged commit f9f5058 into main Feb 16, 2024
12 of 13 checks passed
@ncooke3 ncooke3 deleted the nc/pm-subspec-testing branch February 16, 2024 01:31
@ncooke3 ncooke3 mentioned this pull request Mar 14, 2024
Closed
yonglam
yonglam reviewed Mar 28, 2024
View reviewed changes
Copy link

@yonglam yonglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why the SDK's version is kept the same? I think we should increase to 7.12.1 to let user update it. Right?

s.version = '7.12.0'

@ncooke3
Copy link
Member Author

ncooke3 commented Mar 28, 2024

I'm wondering why the SDK's version is kept the same? I think we should increase to 7.12.1 to let user update it. Right?

s.version = '7.12.0'

Hi @yonglam, the corresponding podspec version bump was done in a separate PR, #145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonglam yonglam yonglam left review comments

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS 17 New required reason API
4 participants
@ncooke3 @google-oss-bot @paulb777 @yonglam