Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specifying default extractors explicitly #2399

Closed

Conversation

emakar
Copy link
Contributor

@emakar emakar commented Jan 31, 2017

so that proguard is possible to shrink unused Extractors

similar to v2 change: f9f95d6

so that proguard is possible to delete unused Extractors could be shrinked
@ojw28
Copy link
Contributor

ojw28 commented Jan 31, 2017

We're only accepting bug fixes into V1 at this point. Move to V2 for shiny new things ;).

@emakar
Copy link
Contributor Author

emakar commented Jan 31, 2017

I'd be glad to move to V2, however we are stuck on dex limit (and cannot afford multidex for various reasons). That said, I've checked V2 methods output and even with unused extractors being shrinked it's still far above V1's. With mp3, mp4 extractors V1 (with this change) gives 628 methods, while V2 - about 1K.


I understand this could hardly be considered as a bug fix, however the change fixes 'outside single dex issue' for me and makes library a little bit more comfy, leaving space for 'soft' migration to V2 in the future

@ojw28
Copy link
Contributor

ojw28 commented Jan 31, 2017

Not being able to use multidex for various (unspecified) reasons doesn't sound like an ExoPlayer problem. This is something you'll likely need to resolve locally. Sorry.

@emakar
Copy link
Contributor Author

emakar commented Jan 31, 2017

That's sad, but sounds reasonable :)
I'll try to look at V2 closer, there should possibly be more space for similar changes. Thanks

@emakar emakar closed this Jan 31, 2017
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants