Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hls adaptive streaming not working for audio only #5313

Open
dmytro-ostapovets opened this issue Dec 25, 2018 · 13 comments
Open

Hls adaptive streaming not working for audio only #5313

dmytro-ostapovets opened this issue Dec 25, 2018 · 13 comments
Assignees

Comments

@dmytro-ostapovets
Copy link

Issue description

Hls adaptive streaming not working with our Audio tracks (Hls file doesn't contain Video track)
We tested Exoplayer demo app, just replaced Hls source by our link.
Player always selects default stream with BANDWIDTH=140800, and never switches to BANDWIDTH=281600, tested on wifi connection.

Reproduction steps

Just replace HlsSource link in demo app:
case C.TYPE_HLS: return new HlsMediaSource.Factory(dataSourceFactory) // .setPlaylistParserFactory( // new DefaultHlsPlaylistParserFactory(getOfflineStreamKeys(uri))) .createMediaSource(Uri.parse("our hls url here"));

Link to test content

Link will be provided by email

Version of ExoPlayer being used

Exoplayer 2.9.3, branch release-v2

Device(s) and version(s) of Android being used

Google Pixel, Android 9.0

A full bug report captured from the device

Bug report will be provided by email

@ojw28
Copy link
Contributor

ojw28 commented Dec 29, 2018

We come up with a pretty weird set of tracks for this content (looking at the master playlist, I think the correct result would be if we ended up with just Group 0):

EventLogger:   Renderer:1 [
EventLogger:     Group:0, adaptive_supported=YES_NOT_SEAMLESS [
EventLogger:       [ ] Track:0, id=0, mimeType=audio/mp4a-latm, bitrate=140800, codecs=mp4a.40.2, channels=2, sample_rate=44100, supported=YES
EventLogger:       [ ] Track:1, id=1, mimeType=audio/mp4a-latm, bitrate=281600, codecs=mp4a.40.2, channels=2, sample_rate=44100, supported=YES
EventLogger:     ]
EventLogger:     Group:1, adaptive_supported=N/A [
EventLogger:       [X] Track:0, id=group_128k:audio_0, mimeType=audio/mp4a-latm, codecs=mp4a.40.2, channels=2, sample_rate=44100, label=audio_0, supported=YES
EventLogger:     ]
EventLogger:     Group:2, adaptive_supported=N/A [
EventLogger:       [ ] Track:0, id=group_256k:audio_0, mimeType=audio/mp4a-latm, codecs=mp4a.40.2, channels=2, sample_rate=44100, label=audio_0, supported=YES
EventLogger:     ]
EventLogger:   ]

ojw28 pushed a commit that referenced this issue Jan 8, 2019
ojw28 pushed a commit that referenced this issue Jan 15, 2019
@ojw28 ojw28 closed this as completed Jan 21, 2019
tonihei pushed a commit that referenced this issue Mar 26, 2019
Issue: #5596

This arguably made a worse problem than it solved, and also I think subtly broken HLS
downloads by changing which renditions HlsMasterPlaylist.copy would retain in some
cases. Reverting as a mini step toward removing smart logic from the HLS playlist parser.

*** Original commit ***

Expand check for muxed audio media tags to include uris that match variants

Issue:#5313

***

PiperOrigin-RevId: 240348969
@ojw28 ojw28 reopened this Apr 16, 2019
@ojw28
Copy link
Contributor

ojw28 commented Apr 16, 2019

Reopening this because the issue will be reintroduced in 2.10 (the original fix caused another issue that was worse than the one that it fixed).

@jakoss

This comment has been minimized.

@jofth
Copy link

jofth commented Sep 4, 2019

Is #5313 still an open bug in release 2.10.3?

@AquilesCanta
Copy link
Contributor

@jofth, the answer is yes.

For internal reference, IIRC [Internal ref: cr/252046149] fixes this issue and #6006.

@jofth
Copy link

jofth commented Sep 4, 2019

Thanks @AquilesCanta - as we currently use audio only HLS adaptive streaming is there a planned release that will resolve this, and until then a suggested work around?

@AquilesCanta Our team's observation is that when using an HLS adaptive playlist that is audio only, if the default stream fails (404s for example) then ExoPlayer does not try the next stream in the playlist.

@palvaibhav89
Copy link

palvaibhav89 commented Nov 12, 2020

Hi i am getting Same issue.
Screenshot 2020-11-11 at 1 17 40 PM

@ojw28 PLease give us a solution. @jofth is their any solution you got?
Currently i am using 2.12.1 version.

@jofth
Copy link

jofth commented Nov 12, 2020

@palvaibhav89 nope, our solution was to stop using hls for audio only streams and use streaming mp3 instead.

@palvaibhav89
Copy link

palvaibhav89 commented Mar 21, 2022

@ojw28 is this issue still open? Is there any fix for this on the way?

@palvaibhav89
Copy link

@AquilesCanta Is there any hope to get this fixed?

@AquilesCanta
Copy link
Contributor

Christos, from my comment above:

For internal reference, IIRC [Internal ref: cr/252046149] fixes this issue and #6006.

@palvaibhav89
Copy link

@christosts Hi, Do you need any info or data?

@kmrinmoy07
Copy link

We are still facing this issue in 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants