Skip to content

Commit

Permalink
Add device info to CastPlayer
Browse files Browse the repository at this point in the history
Issue: androidx/media#142
PiperOrigin-RevId: 468666737
(cherry picked from commit d6442f6)
marcbaechinger authored and microkatz committed Aug 19, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 60d3e8e commit f933666
Showing 2 changed files with 15 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -80,6 +80,10 @@
*/
public final class CastPlayer extends BasePlayer {

/** The {@link DeviceInfo} returned by {@link #getDeviceInfo() this player}. */
public static final DeviceInfo DEVICE_INFO =
new DeviceInfo(DeviceInfo.PLAYBACK_TYPE_REMOTE, /* minVolume= */ 0, /* maxVolume= */ 0);

static {
ExoPlayerLibraryInfo.registerModule("goog.exo.cast");
}
@@ -727,10 +731,10 @@ public CueGroup getCurrentCues() {
return CueGroup.EMPTY_TIME_ZERO;
}

/** This method is not supported and always returns {@link DeviceInfo#UNKNOWN}. */
/** This method always returns {@link CastPlayer#DEVICE_INFO}. */
@Override
public DeviceInfo getDeviceInfo() {
return DeviceInfo.UNKNOWN;
return DEVICE_INFO;
}

/** This method is not supported and always returns {@code 0}. */
Original file line number Diff line number Diff line change
@@ -63,6 +63,7 @@
import android.net.Uri;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.google.android.exoplayer2.C;
import com.google.android.exoplayer2.DeviceInfo;
import com.google.android.exoplayer2.MediaItem;
import com.google.android.exoplayer2.MediaMetadata;
import com.google.android.exoplayer2.PlaybackParameters;
@@ -1864,6 +1865,14 @@ public void setMediaItems_equalMetadata_doesNotNotifyOnMediaMetadataChanged() {
verify(mockListener, never()).onMediaMetadataChanged(any());
}

@Test
public void getDeviceInfo_returnsCorrectDeviceInfoWithPlaybackTypeRemote() {
DeviceInfo deviceInfo = castPlayer.getDeviceInfo();

assertThat(deviceInfo).isEqualTo(CastPlayer.DEVICE_INFO);
assertThat(deviceInfo.playbackType).isEqualTo(DeviceInfo.PLAYBACK_TYPE_REMOTE);
}

private int[] createMediaQueueItemIds(int numberOfIds) {
int[] mediaQueueItemIds = new int[numberOfIds];
for (int i = 0; i < numberOfIds; i++) {

0 comments on commit f933666

Please sign in to comment.