Fix repl output after .pseudoToNative changes #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR #450 Interpreter.prototype.pseudoToNative was modified to make the JSON.stringify builtin behave more correctly (per ES5.1 spec). Unfortunately this meant that in repl any expression that yeilded a function would be shown as having value undefined. Fix repl so that if the expression evaluates to a function that function is printed. (It will still hide methods, as JSON.stringify does. But this is better than before, and perfecting repl is not a priority at the moment.)
NeilFraser
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #450
Interpreter.prototype.pseudoToNativewas modified to makethe
JSON.stringifybuiltin behave more correctly (per ES5.1 spec).Unfortunately this meant that in
replany expression that yieldeda function would be shown as having value undefined.
Fix
replso that if the expression evaluates to a function thatfunction is printed. (It will still hide methods, as
JSON.stringifydoes. But this is better than before, and perfecting
replis nota priority at the moment.)