Improvements to output rendering for VSCode. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSCode's IPython notebook rendering works slightly differently than JupyterLab and Colab. This commit makes a few changes to improve the way Treescope works in this setting: - Inserts and removes small amounts of padding, to trigger VSCode to re-evaluate whether "cell output" blocks should be hidden. Previously, VSCode would have false positive and false negatives about which blocks are empty due to Treescope's output-stealing behavior. Adding and removing padding forces VSCode to identify that the temporary output cell is now empty and the final output cell now contains content. - Changes the treescope root element to have a white background that extends the full width of the output cell, which can improve appearance when using Treescope to render small values in a dark-mode theme (since Treescope outputs always appear with a white background and dark mode is not yet supported inside a rendering).
danieldjohnson
force-pushed
the
vscode_output_fix
branch
from
9a4bab9 to
61c4773
Compare
Errors while generating docs previously led to silent failures in the documentation site. This commit fixes the specific failure by upgrading Penzai, ensuring that it is compatible with new JAX versions. It also enables error checking to fail documentation builds if the notebook execution fails.
danieldjohnson
force-pushed
the
vscode_output_fix
branch
from
61c4773 to
09de497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode's IPython notebook rendering works slightly differently than JupyterLab and Colab. This commit makes a few changes to improve the way Treescope works in this setting:
Also fixes some errors in building documentation.