-
Notifications
You must be signed in to change notification settings - Fork 29
cephes.stdtr not increasing?! #19
base: master
Are you sure you want to change the base?
Conversation
Woot woot. Of course the error is still just a printf, no proper error report, nor any nice vectorization, but at least it's callable
As extracted from Fortran sources
See new repository jucor/torch-cdflib. This commit reverts all the cdflib-related modifications.
This reverts commit cf6fffe.
And voila, created jucor/torch-cdflib :-) You were right Daniel, that's much cleaner that way. Now there's the question of which test we should add to torch-cephes? Some tests that assert that the bug is here? That would probably sound the most coherent, but it feels weird to add tests that success for the presence of a bug. |
Nice one! Awesome job. Thanks for sorting out that doc I added too, I just realised I put it in the wrong place! Hmm, yes, not too sure about the tests. I'm almost tempted to say we should just remove stdtr from torch-cephes, actually, unless there are cases where that implementation is better…? Cheers On 2 Dec 2013, at 22:14, Julien Cornebise [email protected] wrote:
|
Hi @d11 |
Ping @d11 @akfidjeland. |
Wow!