Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

cephes.stdtr not increasing?! #19

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

cephes.stdtr not increasing?! #19

wants to merge 11 commits into from

Conversation

jucor
Copy link
Contributor

@jucor jucor commented Dec 2, 2013

Wow!

t7> return cephes.stdtr(10, 10e150)
1
t7> return cephes.stdtr(10, 10e300)
0.5

jucor and others added 9 commits December 2, 2013 17:55
Woot woot. Of course the error is still just a printf,
no proper error report, nor any nice vectorization,
but at least it's callable
As extracted from Fortran sources
See new repository jucor/torch-cdflib.
This commit reverts all the cdflib-related modifications.
@jucor
Copy link
Contributor Author

jucor commented Dec 2, 2013

And voila, created jucor/torch-cdflib :-) You were right Daniel, that's much cleaner that way.

Now there's the question of which test we should add to torch-cephes? Some tests that assert that the bug is here? That would probably sound the most coherent, but it feels weird to add tests that success for the presence of a bug.

@d11
Copy link
Contributor

d11 commented Dec 2, 2013

Nice one! Awesome job. Thanks for sorting out that doc I added too, I just realised I put it in the wrong place!

Hmm, yes, not too sure about the tests. I'm almost tempted to say we should just remove stdtr from torch-cephes, actually, unless there are cases where that implementation is better…?

Cheers
Dan

On 2 Dec 2013, at 22:14, Julien Cornebise [email protected] wrote:

And voila, created jucor/torch-cdflib :-) You were right Daniel, that's much cleaner that way.

Now there's the question of which test we should add to torch-cephes? Some tests that assert that the bug is here? That would probably sound the most coherent, but it feels weird to add tests that success for the presence of a bug.


Reply to this email directly or view it on GitHub.

@jucor
Copy link
Contributor Author

jucor commented Feb 1, 2015

Hi @d11
I'm going through our few open pull-requests. Can't remember what we decided for this one. Shall we discuss about bringing github.com/jucor/torch-cdflib into deepmind/ ?I do not think anyone is using it yet, but since @dpfau and @theoweber are up to getting torch-distributions a bit more efficient, it could be a good time to bring cdflib up to speed.
What do you think?

@jucor
Copy link
Contributor Author

jucor commented Apr 24, 2015

Ping @d11 @akfidjeland.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants