Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subtreeangmom sensor instead of subtreelinvel #136

Closed
wants to merge 2 commits into from
Closed

Use subtreeangmom sensor instead of subtreelinvel #136

wants to merge 2 commits into from

Conversation

miguel131299
Copy link

A subtreelinvel was mistakenly being used instead of the subtreeangmom as the name of the sensor would sugest

A subtreelinvel was mistakenly being used instead of the subtreeangmom as the name of the sensor would sugest
@google-cla
Copy link

google-cla bot commented Jul 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@thowell
Copy link
Collaborator

thowell commented Jul 23, 2023

LGTM

yuvaltassa
yuvaltassa previously approved these changes Jul 24, 2023
@yuvaltassa
Copy link
Contributor

Unclear why the tests are failing...
@nimrod-gileadi @thowell @erez-tom any ideas?

@nimrod-gileadi
Copy link
Collaborator

The build was failing in MuJoCo. I think this was the failure that was introduced by google-deepmind/mujoco@5fcdae7 and fixed by google-deepmind/mujoco@7603b07.

If we rerun the tests now against the latest MuJoCo I expect they'll pass.

@thowell
Copy link
Collaborator

thowell commented Aug 7, 2023

@miguel131299 can you please update this PR (use an empty commit so the tests are rerun), then we can merge.

@miguel131299 miguel131299 closed this by deleting the head repository Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants