Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the code to always create variables and computations of the same dtype as the its inputs. Previously, if float64 was enabled, some of the results would be (potentially incorrectly) promoted to higher precision. #82

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Nov 22, 2022

Updates the code to always create variables and computations of the same dtype as the its inputs. Previously, if float64 was enabled, some of the results would be (potentially incorrectly) promoted to higher precision.

@copybara-service copybara-service bot force-pushed the test_490195155 branch 2 times, most recently from 1d92066 to 3d7d410 Compare November 22, 2022 11:27
@copybara-service copybara-service bot changed the title * Updates to support correct dtypes when float64 is enabled. Updates the code to always create variables and computations of the same dtype as the its inputs. Previously, if float64 was enabled, some of the results would be (potentially incorrectly) promoted to higher precision. Feb 9, 2023
…ame dtype as the its inputs. Previously, if float64 was enabled, some of the results would be (potentially incorrectly) promoted to higher precision.

PiperOrigin-RevId: 508391517
@copybara-service copybara-service bot merged commit c4e5765 into main Feb 9, 2023
@copybara-service copybara-service bot deleted the test_490195155 branch February 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant