Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Fix: Missing mp_holistic in PoseEstimation example #1969

Closed
wants to merge 1 commit into from

Conversation

chr0nikler
Copy link

Seems like the var mp_holistic is referenced without being instantiated. Also looks like the preference is to create mp_x var rather than mp.solutions.holistic inline, so done at the top with the others.

@google-cla
Copy link

google-cla bot commented May 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@chr0nikler
Copy link
Author

@googlebot I signed it!

@jiuqiant
Copy link
Contributor

jiuqiant commented Sep 1, 2021

Thanks for reporting this. Fixed in our internal code base upstream, and will be pushed to GitHub in the next release.

@jiuqiant jiuqiant self-assigned this Sep 1, 2021
@jiuqiant
Copy link
Contributor

jiuqiant commented Sep 2, 2021

Fixed in 6abec12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants