Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELATED: FET-769 Migrate to pure ESM #3802

Merged
1 commit merged into from
Jun 29, 2023
Merged

RELATED: FET-769 Migrate to pure ESM #3802

1 commit merged into from
Jun 29, 2023

Conversation

ivanmjartan
Copy link
Contributor

Supported PR commands:

Command Description
ok to test Re-run standard checks
extended check sonar SonarQube tests
extended test - backstop BackstopJS tests
E2E Cypress tests commands - TIGER
extended test - tiger-cypress - isolated <testName> Run isolated tests running against recorded Tiger backend.
extended test - tiger-cypress - record <testName> Create a new recording for isolated Tiger tests.
extended test - tiger-cypress - integrated <testName> Run integrated tests against live backend
E2E Cypress tests commands - BEAR
extended test - cypress - isolated <testName> Run isolated tests running against recorded Bear backend.
extended test - cypress - record <testName> Create a new recording for isolated Bear tests.
extended test - cypress - integrated <testName> Run integrated tests against live backend
Compatibility matrix test commands - TIGER Backend
extended test - matrix-test <AIO_version> Run integrated tests against AIO versions.

<testName> in cypress commands is used to filter specfiles. Example, to run record with BEAR backend

  • Against dashboard.spec.ts and drilling.spec.ts, execute command extended test - cypress - record dashboard,drilling
  • Against all specfiles, execute command extended test - cypress - record or extended test - cypress - record *

<AIO_version> in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins build

  • To run with master and stable, execute command extended test - matrix-test master,stable or extended test - matrix-test latest
  • To run with specific version,ex: 2.3.0 and 2.3.1, execute command extended test - matrix-test 2.3.0,2.3.1
  • In case <AIO_version> is empty, read versions from file compTigerVersions.txt of this repo

PR Checklist

  • commit messages adhere to the commit message guidelines
  • review was done by a Code owner if necessary (if you think it is not necessary, explain the reasoning in the description or in a comment)
  • check passes
  • extended test - backstop passes
  • extended test - tiger-cypress - record to record new mapping files (Tiger BE)
  • extended test - cypress - record to record new mapping files (Bear BE)
  • extended test - tiger-cypress - isolated passes
  • extended test - cypress - isolated passes
  • extended test - tiger-cypress - integrated passes
  • rush change was run if applicable

@ivanmjartan ivanmjartan requested a review from kandl as a code owner June 14, 2023 15:02
@ghost
Copy link

ghost commented Jun 14, 2023

Merge Failed.

Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator.

2 similar comments
@ghost
Copy link

ghost commented Jun 14, 2023

Merge Failed.

Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator.

@ghost
Copy link

ghost commented Jun 16, 2023

Merge Failed.

Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator.

@ghost
Copy link

ghost commented Jun 16, 2023

Merge Failed.

Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator.

@ivanmjartan ivanmjartan force-pushed the IMJ-FET-769-fin branch 2 times, most recently from 18d50f8 to eb47f9a Compare June 16, 2023 13:38
@ghost
Copy link

ghost commented Jun 16, 2023

Build in pipeline check aborted.

@ghost
Copy link

ghost commented Jun 16, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 16, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 16, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 16, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Build failed (check pipeline).

@ghost
Copy link

ghost commented Jun 19, 2023

Merge Failed.

Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator.

@yenkins
Copy link

yenkins commented Jun 29, 2023

Link to Storybook test result: https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-backstop-tests/2280/artifact/libs/sdk-ui-tests/backstop/output/html-report/index.html

@ghost
Copy link

ghost commented Jun 29, 2023

Build failed (check-extended pipeline).

kandl
kandl approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@kandl kandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

common/scripts/directory.mjs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this file with hardcoded path.
If we want to keep the script with extensions fix, we should make it parametrized, but I think we can remove it as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

common/scripts/fix-ext.mjs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this script? Or at least, make it parametrized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

common/scripts/fix-invariant.mjs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this script? Or at least, make it parametrized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

common/scripts/fix-lodash.mjs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this script? Or at least, make it parametrized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs/contributing.md Outdated
@@ -45,7 +45,7 @@ Always run `rush install`; this will make sure all the dependencies from the loc
the projects managed in the repository. After that run `rush build`.

In case the pull brings in new projects or large bulk of changes, it is safer (albeit more time-consuming) to run
`rush install && rush link --force && rush clean && rush rebuild`.
`rush purge rush install && rush rebuild`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be rush clean && rush purge && rush install && rush rebuild ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

examples/playground/.eslintrc.cjs
"plugin:sonarjs/recommended",
"plugin:regexp/recommended",
"plugin:react-hooks/recommended",
"../../.eslintrc.react.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this removal (of react eslint extend)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added back

examples/playground/webpack.config.cjs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use .js or .mjs for the webpack config?

examples/playground/webpack.config.cjs
@@ -106,24 +106,39 @@ module.exports = async (env, argv) => {
entry: ["./src/index.tsx"],
target: "web",
mode: isProduction ? "production" : "development",
experiments: {
outputModule: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use this, as it's still experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have no other option

examples/playground/webpack.config.cjs
publicPath: `${basePath}/`,
library: {
type: "module",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, playground is not a library, does this really need to be there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its necessary

libs/api-client-bear/.dependency-cruiser.cjs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, is it feasible to migrate this config to esm? (we can handle it as a followup)

@kandl kandl added the merge label Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Build in pipeline check aborted.

@yenkins
Copy link

yenkins commented Jun 29, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR3802

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Build failed (gate pipeline).

@ivanmjartan
Copy link
Contributor Author

extended test - matrix-test

@ghost
Copy link

ghost commented Jun 29, 2023

Build failed (check-extended pipeline).

@ivanmjartan
Copy link
Contributor Author

extended test - matrix-test

@ghost
Copy link

ghost commented Jun 29, 2023

Build failed (check-extended pipeline).

@ghost
Copy link

ghost commented Jun 29, 2023

Build succeeded (check pipeline).

@ivanmjartan
Copy link
Contributor Author

extended test - matrix-test

@ghost
Copy link

ghost commented Jun 29, 2023

Build failed (check-extended pipeline).

@ivanmjartan
Copy link
Contributor Author

extended test - matrix-test

@ghost
Copy link

ghost commented Jun 29, 2023

Build succeeded (check pipeline).

@ghost
Copy link

ghost commented Jun 29, 2023

Build succeeded (check-extended pipeline).

@ghost
Copy link

ghost commented Jun 29, 2023

Build in pipeline check aborted.

@ghost
Copy link

ghost commented Jun 29, 2023

Build succeeded (check pipeline).

@yenkins
Copy link

yenkins commented Jun 29, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR3802

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jun 29, 2023
@ghost ghost merged commit 8249aef into gooddata:master Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Build succeeded (gate pipeline).

@pbenes pbenes mentioned this pull request Sep 24, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandl kandl kandl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivanmjartan @scavnickyj @yenkins @kandl @ivan-nejezchleb