Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to a weird issue discovered by @guilledk where if you pass in a
mngrs=(<generator comprehension>)
, you end up with an empty sequence in the loop insidetrionics.gather_contexts()
and then a hang due to waiting on theall_entered: trio.Event
just after the loop.This solves the issue by greedly converting the
mngrs
sequence to a list and ensuring its size and otherwise raising aValueError
.Further TODO for this to land:
add tests for both the generator and empty list input casesthere's no real reason for this, and further trying to jam in the logic in apytest
parametrization is janky..Other additions part of this patch:
open_actor_cluster()
helper such that any kwarg toopen_root_actor()
can be used