Drop the "main" task via kwarg idea #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 2, 2018 15:24
Stop worrying about a "main task" in each actor and instead add an
additional `ActorNursery.run_in_actor()` method which wraps calls
to create an actor and run a lone RPC task inside it. Note this
adjusts the public API of `ActorNursery.start_actor()` to drop
its `main` kwarg.
The dirty deats of making this possible:
- each spawned RPC task is now tracked with a specific cancel scope such
that when the actor is cancelled all ongoing responders are cancelled
before any IPC/channel machinery is closed (turns out that spawning
new actors from `outlive_main=True` actors was probably borked before
finally getting this working).
- make each initial RPC response be a packet which describes the
`functype` (eg. `{'functype': 'asyncfunction'}`) allowing for async
calls/submissions by client actors (this was required to make
`run_in_actor()` work - `Portal._submit()` is the new async method).
- hooray we can stop faking "main task" results for daemon actors
- add better handling/raising of internal errors caught in the bowels of
the `Actor` itself.
- drop the rpc spawning nursery; just use the `Actor._root_nursery`
- only wait on `_no_more_peers` if there are existing peer channels that
are actually still connected.
- an `ActorNursery.__aexit__()` now implicitly waits on `Portal.result()` on close
for each `run_in_actor()` spawned actor.
- handle cancelling partial started actors which haven't yet connected
back to the parent
Resolves #24
vodik
approved these changes
Aug 4, 2018
| if functype == 'function' or functype == 'asyncfunction': | ||
| resp_type = 'return' | ||
| elif functype == 'asyncgen': | ||
| resp_type = 'yield' |
There was a problem hiding this comment.
Have you considered using an enum here instead of strings?
tractor/_actor.py
Outdated
| log.debug( | ||
| f"Cancelling all tasks for {chan} from {chan.uid}") | ||
| scopes = self._rpc_tasks.pop(chan, None) | ||
| if scopes: |
There was a problem hiding this comment.
If you do scopes = self._rpc_tasks.pop(chan, ()) instead, you can skip the if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop worrying about a "main task" in each actor and instead add an
additional
ActorNursery.run_in_actor()method which wraps callsto create an actor and run a lone RPC task inside it. Note this
adjusts the public API of
ActorNursery.start_actor()to dropits
mainkwarg.The dirty deats of making this possible:
that when the actor is cancelled all ongoing responders are cancelled
before any IPC/channel machinery is closed (turns out that spawning
new actors from
outlive_main=Trueactors was probably borked beforefinally getting this working).
functype(eg.{'functype': 'asyncfunction'}) allowing for asynccalls/submissions by client actors (this was required to make
run_in_actor()work -Portal._submit()is the new async method).the
Actoritself.Actor._root_nursery_no_more_peersif there are existing peer channels thatare actually still connected.
ActorNursery.__aexit__()now implicitly waits onPortal.result()on closefor each
run_in_actor()spawned actor.back to the parent
Resolves #24
This will require updates to #11 obviously.
ping @vodik!