Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin rpc_module_paths deprecation #187

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Begin rpc_module_paths deprecation #187

merged 3 commits into from
Jan 14, 2021

Conversation

goodboy
Copy link
Owner

@goodboy goodboy commented Jan 5, 2021

Start at #182.

Adds warning for now to allow transitioning client code in the short term.

@goodboy goodboy requested a review from guilledk January 5, 2021 13:37
@goodboy goodboy force-pushed the deprecate_rpcmodpaths branch from c8ca175 to 365ac76 Compare January 9, 2021 01:57
Base automatically changed from implicit_runtime to master January 9, 2021 03:07
@goodboy goodboy force-pushed the deprecate_rpcmodpaths branch from 365ac76 to 5ed5d18 Compare January 9, 2021 03:09
Using `None` as the default key for a `@msg.pub` can cause conflicts if
there is more then one "taskless" (no tasks={,} passed) pub offered on
an actor... So instead use the first trio "task name" (usually just the
function name) instead thus avoiding this very hard to debug and
understand problem.

Probably should throw in a test but I'm super lazy today.
@goodboy goodboy merged commit 8fdab8e into master Jan 14, 2021
@goodboy goodboy deleted the deprecate_rpcmodpaths branch January 14, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant