Add grpc-web test and update grpc-web dependency version. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gonzojive
commented
Oct 7, 2023
•
gonzojive
commented
- Update repository dependency to point to grpc/grpc-web. Update ES6 .d.ts imports with comment about corresponding proto import path grpc/grpc-web#1330 was merged, so there's no longer a need to depend on a fork.
- Add a test of the grpc-web functionality and require the grpc-web node module.
- Ensure all rewritten imports include the ".mjs" suffix. It was previously omitted for some imports.
//ts_proto/codegen:delegating_plugin is the only plugin supported by this bazel library. Deleting the others clarifies this.
grpc/grpc-web#1330 was merged, so there's no longer a need to depend on a fork.
gonzojive
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.