Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gio up #764

Merged
merged 4 commits into from
May 4, 2023
Merged

Gio up #764

merged 4 commits into from
May 4, 2023

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Apr 27, 2023

Please take a look.

@sbinet
Copy link
Member Author

sbinet commented Apr 27, 2023

this isn't the final answer: the new Gio API doesn't lend itself very nicely with our Push/Pop semantics.
see 1 for more details.

(but we don't use explicitly Push/Pop in the vg/vggio tests. I'd expect plot/plotter.Field.Plot to fail)

also, it seems the latest Gio version has a somewhat different kerning algorithm.

@sbinet sbinet force-pushed the gio-up branch 2 times, most recently from 6e3c3cb to 9d7bc4d Compare April 27, 2023 17:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 75.20% and project coverage change: +1.69 🎉

Comparison is base (78cf2c9) 73.43% compared to head (10ff9ab) 75.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   73.43%   75.13%   +1.69%     
==========================================
  Files          56       58       +2     
  Lines        5176     7420    +2244     
==========================================
+ Hits         3801     5575    +1774     
- Misses       1191     1649     +458     
- Partials      184      196      +12     
Impacted Files Coverage Δ
vg/vggio/vggio.go 79.11% <72.97%> (ø)
vg/vggio/context.go 100.00% <100.00%> (ø)

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

kortschak
kortschak previously approved these changes Apr 27, 2023
@sbinet
Copy link
Member Author

sbinet commented Apr 28, 2023

this needs https://lists.sr.ht/~eliasnaur/gio-patches/patches/40703

I haven't understood (yet?) why the embedded image is so blurry.

@sbinet
Copy link
Member Author

sbinet commented May 2, 2023

@sbinet
Copy link
Member Author

sbinet commented May 2, 2023

so the blur comes from a different filtering algorithm used deep inside Gio.
I guess we'll have to do the rescaling by hand CPU-side, with image/draw.

@sbinet
Copy link
Member Author

sbinet commented May 3, 2023

well, this is the best I could come up with.
still not on par with what we used to have though...

(I have tried different filters from x/image/draw. the NN is what looked best to my eyes. perhaps we should allow to optionally provide a way to use a user-provided x/image/draw.Scaler ?)

PTAL

Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH (maybe my eyes are too blurry already) I can't really see the difference.

@sbinet sbinet merged commit 1699fcb into gonum:master May 4, 2023
@sbinet sbinet deleted the gio-up branch May 4, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants