Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: bump to Go-1.20, drop Go-1.18 #760

Merged
merged 2 commits into from
Feb 21, 2023
Merged

all: bump to Go-1.20, drop Go-1.18 #760

merged 2 commits into from
Feb 21, 2023

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Feb 21, 2023

Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Base: 73.34% // Head: 74.81% // Increases project coverage by +1.46% 🎉

Coverage data is based on head (5e3a35a) compared to base (74e8112).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   73.34%   74.81%   +1.46%     
==========================================
  Files          56       58       +2     
  Lines        5159     7345    +2186     
==========================================
+ Hits         3784     5495    +1711     
- Misses       1191     1655     +464     
- Partials      184      195      +11     
Impacted Files Coverage Δ
vg/geom.go 76.00% <0.00%> (-5.25%) ⬇️
plotter/quartile.go 67.97% <0.00%> (-2.12%) ⬇️
palette/hsva.go 89.74% <0.00%> (-1.79%) ⬇️
text/plain.go 88.63% <0.00%> (-1.69%) ⬇️
plotter/errbars.go 86.56% <0.00%> (-1.44%) ⬇️
vg/vgpdf/vgpdf.go 68.58% <0.00%> (-1.29%) ⬇️
axis.go 85.96% <0.00%> (-0.99%) ⬇️
vg/tee.go 76.00% <0.00%> (-0.93%) ⬇️
palette/moreland/smooth.go 85.91% <0.00%> (-0.63%) ⬇️
plotter/line.go 90.38% <0.00%> (-0.42%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sbinet
Copy link
Member Author

sbinet commented Feb 21, 2023

PTAL.

@kortschak it seems the 1.18.x builds for darwin and linux are still referenced (and marked required.)

@sbinet sbinet merged commit 1cd1f0e into gonum:master Feb 21, 2023
@sbinet sbinet deleted the go120 branch February 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants