Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds plotutil example image width/height unit #756

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Adds plotutil example image width/height unit #756

merged 2 commits into from
Feb 12, 2023

Conversation

zyluo
Copy link
Contributor

@zyluo zyluo commented Jan 9, 2023

Please take a look.

sbinet
sbinet previously approved these changes Jan 10, 2023
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet sbinet requested a review from kortschak January 10, 2023 10:19
Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbinet Do you know why the test expectations are no longer matching?

plotutil/main.go Outdated Show resolved Hide resolved
sbinet
sbinet previously approved these changes Jan 14, 2023
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(could you please add yourself to the AUTHORS and/or CONTRIBUTORS files of gonum/gonum ? thanks)

@sbinet
Copy link
Member

sbinet commented Jan 14, 2023

@kortschak ah, I didn't notice.
I guess another change in the X/wayland stack that ripples on vg/vggio...

@zyluo
Copy link
Contributor Author

zyluo commented Jan 22, 2023

I guess this patch is gated by vggio?

@kortschak
Copy link
Member

If you rebase this onto master, it should pass.

@zyluo
Copy link
Contributor Author

zyluo commented Feb 11, 2023

rebased to master

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Base: 73.34% // Head: 74.77% // Increases project coverage by +1.42% 🎉

Coverage data is based on head (fafe8fe) compared to base (f21f923).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   73.34%   74.77%   +1.42%     
==========================================
  Files          56       58       +2     
  Lines        5159     7345    +2186     
==========================================
+ Hits         3784     5492    +1708     
- Misses       1191     1657     +466     
- Partials      184      196      +12     
Impacted Files Coverage Δ
vg/geom.go 76.00% <0.00%> (-5.25%) ⬇️
plotter/quartile.go 67.97% <0.00%> (-2.12%) ⬇️
palette/hsva.go 89.74% <0.00%> (-1.79%) ⬇️
text/plain.go 88.63% <0.00%> (-1.69%) ⬇️
plotter/errbars.go 86.56% <0.00%> (-1.44%) ⬇️
vg/vgpdf/vgpdf.go 68.58% <0.00%> (-1.29%) ⬇️
axis.go 85.96% <0.00%> (-0.99%) ⬇️
vg/tee.go 76.00% <0.00%> (-0.93%) ⬇️
palette/moreland/smooth.go 85.91% <0.00%> (-0.63%) ⬇️
plotter/line.go 90.38% <0.00%> (-0.42%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zyluo zyluo requested review from kortschak and sbinet and removed request for kortschak and sbinet February 11, 2023 23:16
Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kortschak kortschak merged commit 1e31f33 into gonum:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants