-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds plotutil example image width/height unit #756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbinet Do you know why the test expectations are no longer matching?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(could you please add yourself to the AUTHORS
and/or CONTRIBUTORS
files of gonum/gonum
? thanks)
@kortschak ah, I didn't notice. |
I guess this patch is gated by vggio? |
If you rebase this onto master, it should pass. |
rebased to master |
Codecov ReportBase: 73.34% // Head: 74.77% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 73.34% 74.77% +1.42%
==========================================
Files 56 58 +2
Lines 5159 7345 +2186
==========================================
+ Hits 3784 5492 +1708
- Misses 1191 1657 +466
- Partials 184 196 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Please take a look.