Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotter: add special handling for image.Uniform #753

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Aug 19, 2022

Fixes #752.

Signed-off-by: Sebastien Binet [email protected]

Please take a look.

plotter/image.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #753 (03497d7) into master (b4f15d2) will increase coverage by 1.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   73.32%   74.77%   +1.45%     
==========================================
  Files          56       58       +2     
  Lines        5154     7345    +2191     
==========================================
+ Hits         3779     5492    +1713     
- Misses       1191     1657     +466     
- Partials      184      196      +12     
Impacted Files Coverage Δ
plotter/image.go 95.12% <100.00%> (+3.45%) ⬆️
vg/geom.go 76.00% <0.00%> (-5.25%) ⬇️
plotter/quartile.go 67.97% <0.00%> (-2.12%) ⬇️
palette/hsva.go 89.74% <0.00%> (-1.79%) ⬇️
text/plain.go 88.63% <0.00%> (-1.69%) ⬇️
plotter/errbars.go 86.56% <0.00%> (-1.44%) ⬇️
vg/vgpdf/vgpdf.go 68.58% <0.00%> (-1.29%) ⬇️
axis.go 85.96% <0.00%> (-0.99%) ⬇️
vg/tee.go 76.00% <0.00%> (-0.93%) ⬇️
palette/moreland/smooth.go 85.91% <0.00%> (-0.63%) ⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kortschak
kortschak previously approved these changes Aug 20, 2022
plotter/image.go Outdated Show resolved Hide resolved
@sbinet sbinet merged commit 5eb6bf0 into gonum:master Aug 20, 2022
@sbinet sbinet deleted the issue-752 branch August 20, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plotter: NewImage does not handle image.Uniform
3 participants