Fixes crashing in project 64 graphics plugin dialog with release build

[fzurita]

With at least MS visual studio 2017, the qt dialog crashes when built in release mode. I was able to track this down to "whole program optimization", so I disabled that and doesn't crash any more.

[fzurita]

By the way, I only disabled "whole program optimization" on GLideNUI and no other projects.

[gonetz]

Please describe the crash scenario. I have no crashes. For example, my release build of the current master:
https://drive.google.com/file/d/1nYqo1GbcaQBTwZRjEc-xZ5YkqEjAJGhi/view?usp=sharing

Built with:

Microsoft Visual Studio Professional 2017 
Version 15.9.11
VisualStudio.15.Release/15.9.11+28307.586
Microsoft .NET Framework
Version 4.7.03056

[fzurita]

It crashes for me simply by opening the configuration dialog with Project 64 32 bit.

Maybe it's because I'm using the prebuilt static QT 5 libraries?

[fzurita]

Either way, the fix is quite simple, and shouldn't affect much of anything since whole program optimization of not going to be a significant performance boost to a UI.

[gonetz]

It crashes for me simply by opening the configuration dialog with Project 64 32 bit.

Do you have that problem with my build?

Either way, the fix is quite simple, and shouldn't affect much of anything since whole program optimization of not going to be a significant oriels boost to a UI.

We don't need that fix if my build works ok for you.
I guess you just did something wrong. Please make sure that you followed my instructions: https://github.com/gonetz/GLideN64/wiki/Build-From-Source-(Windows)
You need to use my prebuilt static QT 5 libraries for VS 2017: https://drive.google.com/open?id=19DtIm6zPBS-7zDD7HEOKcownrVaehrxD
You have to right click on GLideN64 solution and Change Solution QT version on this build.
Then, rebuild GLideNUI only. After that, build the solution.

[fzurita]

Yes, I followed that directions and downloaded the specific version of qt5 prebuilt with vs 2017 linked in the instructions.

That's a good point, I will try your build. Which Windows version are you using?

[fzurita]

@gonetz You build crashes for me too when opening the graphics settings dialog from project 64.

[gonetz]

Which Windows version are you using?

Win 10 Home 64bit.

You build crashes for me too when opening the graphics settings dialog from project 64.

:(
Which Windows version are you using?

[fzurita]

Windows 10 Professional, latest insider build in the fast ring (18875).

[gonetz]

I just tested my VS 2017 build on Win 10 pro, no issues. Are you sure that you run my build and it crashes? How can it be?

@olivieryuyu could you test this build:
https://drive.google.com/file/d/1nYqo1GbcaQBTwZRjEc-xZ5YkqEjAJGhi/view?usp=sharing
on your PC? Just open plugin's the configuration dialog with Project 64.

[fzurita]

Could it be the version of project 64 I'm using? I'm using this version:

https://64dd.org/downloads.html

[gonetz]

I just tried my build with pj64_2019-03-21_64dd - no issues with configuration dialog. A mystic case.

I agree that whole program optimization is not so necessary for GUI, but the fact that it works fine on
all my PCs but crashes for you is quite disturbing.

[fzurita]

Yeah... I can't explain it. I think I have had this problem ever since I can remember.

[fzurita]

I found one report of this issue here: #1574 (comment)

[gonetz]

Ok, the fix is harmless. Approved.

[fallaha56]

Hi, I can just confirm the same crash, with the 66dd build, Public Release 4.0 but also with emuCR build, Win10Pro

Can open all other GUIs for all other GFX plugins just not PJ64, have had this issue for at least a month

Hope this is useful

[gonetz]

emuCR builds are known to be buggy.
But if my Public Release 4.0 crashes for you, it is real problem.

[mitchellcairns]

Yeah the Public Release 4.0 crashes for me as well.

[fzurita]

Feel free to revert this change... It appears to not be harmless unfortunately. But if you revert it, it will start crashing for me though....

[mitchellcairns]

Feel free to revert this change... It appears to not be harmless unfortunately. But if you revert it, it will start crashing for me though....

Just to clarify, it doesn't matter if I'm using Public release 3.0 or 4.0, it still crashes either way.

[Jj0YzL5nvJ]

Sounds like NX/XD bit configured to AlwaysOn... execute bcdedit /enum | find /i "nx" like administrator to know the current setting. The default (optimal) value in commercial Windows versions is OptIn (bcdedit /set nx OptIn).

[gonetz]

@Jj0YzL5nvJ
NX/XD bit was configured to OptIn in my Windows. I set it to AlwaysOn, restarted Windows, but GLideN64 GUI still works fine for me.

[gonetz]

@mitchellcairns what is your Windows version?

[oddMLan]

Maybe try upgrading to a newer version of Qt? Or compiling it using a newer Visual Studio?
The current version also has an annoying tooltip issue, on hover on any of the options that has a info tootip, it never fades away. But if I compile GLideN64 + GLideNUI myself with VS2017, there is no tooltip issue. I only have that issue with the current WIP builds.

[mitchellcairns]

@gonetz I'm on the latest Windows 10 Professional edition; June 2019 update.

[weinerschnitzel]

I wonder if posting an Event Viewer log could help identify what exactly is causing the crash?

[gonetz]

Good idea. @mitchellcairns , could you check the Event Viewer log for details about the crash?