Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes endpoint creds #1325

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Fixes endpoint creds #1325

merged 2 commits into from
Aug 6, 2019

Conversation

manugupt1
Copy link
Member

What is the problem I am trying to address?

SigSegV in Endpoint creds

How is the fix applied?
Found out that the AWS HTTP Client was null

Mention briefly how you have applied the fix.
Start by using default aws config to create http client automatically

Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.

Fixes #1283

@manugupt1 manugupt1 requested a review from a team as a code owner August 6, 2019 03:28
Copy link
Member

@chriscoffee chriscoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✌️

@marwan-at-work marwan-at-work merged commit be908fe into gomods:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AWS ECS credentials
3 participants