Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ts-sinon): implementing ts-sinon package #603

Merged
merged 13 commits into from
Jul 4, 2023
Merged

feat(ts-sinon): implementing ts-sinon package #603

merged 13 commits into from
Jul 4, 2023

Conversation

omermorad
Copy link
Contributor

@omermorad omermorad commented Jun 7, 2023 •
edited
Loading

Description

This pull request introduces the primary implementation of the ts-sinon package. Inspired by the features and ease of use offered by ts-jest, ts-sinon is designed to facilitate a wide array of testing scenarios and requirements.

Through this pull request, our goal is to equip developers with a powerful and efficient mocking tool that seamlessly integrates into their testing workflows, enhancing the robustness and reliability of their tests.

Closes #604

@omermorad omermorad changed the title feat(ts-sinon): implmenting ts-sinon package :) feat(ts-sinon): implementing ts-sinon package Jun 8, 2023
underfisk
underfisk reviewed Jul 1, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
underfisk
underfisk requested changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@underfisk underfisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'm just concern on duplicating code/types but the feature looks pretty handy for sinon users

packages/testing/ts-sinon/src/mocks.ts Show resolved Hide resolved
ali-shabani and others added 7 commits July 2, 2023 00:53
@ali-shabani
fix: fixed the order of metadata to match the exported one (golevelup…
6250292 
…#608)
@MansurAliKoroglu @underfisk
docs(main): add ts-jest to package table (golevelup#597)
3ce1f0f 
Co-authored-by: Rodrigo <[email protected]>
@jclab-joseph @underfisk
build(deps): add missed dependencies and peerDependencies (golevelup#581
4c28a3d 
)

Co-authored-by: Rodrigo <[email protected]>
@underfisk
fix(discovery.service.ts): uses better truth check with lodash isNil (g…
1e3ea9f 
…olevelup#611)

using lodash isNil avoids false positives when checking for meta

golevelup#595
@underfisk
feat(connection.ts): support service property to read consumer tags (g…
7bbfa3f 
…olevelup#612)

Exposes a new "get" method for consumer tags

Closes golevelup#596
@Yehonal @underfisk
fix: missing jest when injectGlobals=false (golevelup#566)
294de30 
Should fix: golevelup#557 (comment)

Co-authored-by: Rodrigo <[email protected]>
@omermorad
Merge remote-tracking branch 'remote/master'
ead4d02
@underfisk
Copy link
Contributor

@omermorad Could you merge the issues and address feedback? If so I'll be willing to push this PR

@omermorad
Copy link
Contributor Author

@omermorad Could you merge the issues and address feedback? If so I'll be willing to push this PR

@underfisk Sure, I apologize for the delay. I'll have time this weekend to fix it; in the meantime, I responded to your comment.

@omermorad omermorad requested a review from underfisk July 4, 2023 15:54
underfisk
underfisk approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@underfisk underfisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as soon as you merge the conflicts and CI passes I'll try to push this

@omermorad
Merge remote-tracking branch 'remote/master'
37525e0 
# Conflicts:
#	packages/common/package.json
#	packages/testing/ts-jest/package-lock.json
#	yarn.lock
@underfisk underfisk enabled auto-merge (squash) July 4, 2023 15:58
auto-merge was automatically disabled July 4, 2023 15:59

Head branch was pushed to by a user without write access

@omermorad omermorad requested a review from underfisk July 4, 2023 16:00
@underfisk underfisk enabled auto-merge (squash) July 4, 2023 16:01
@underfisk
Copy link
Contributor

@omermorad There's an issue with rpc-exception type. Could you add a quick fix so that CI can pass?

auto-merge was automatically disabled July 4, 2023 16:17

Head branch was pushed to by a user without write access

@omermorad omermorad requested a review from underfisk July 4, 2023 16:18
@omermorad
Copy link
Contributor Author

@omermorad There's an issue with rpc-exception type. Could you add a quick fix so that CI can pass?

Trying to, I can't find the problem, why would my changes be related to this package?

@underfisk
Copy link
Contributor

@omermorad There's an issue with rpc-exception type. Could you add a quick fix so that CI can pass?

Trying to, I can't find the problem, why would my changes be related to this package?

It isn't related, all you have to do is add ! to force the null check or simply add a null coalesce because for some reason this often pop in PR's..

@underfisk
Copy link
Contributor

underfisk commented Jul 4, 2023 •
edited
Loading

@omermorad I've fixed the issue and added auto-merge so as soon as the checks pass, it should be good to go

@underfisk underfisk enabled auto-merge (squash) July 4, 2023 18:47
@underfisk underfisk merged commit 29d6bf6 into golevelup:master Jul 4, 2023
WonderPanda pushed a commit that referenced this pull request Jul 18, 2023
@omermorad @ali-shabani
@MansurAliKoroglu @underfisk @jclab-joseph @Yehonal @WonderPanda
feat(ts-sinon): adds new mocking package for sinon users (#603)
4029547 
Co-authored-by: Ali Shabani <[email protected]>
Co-authored-by: MansurAliKoroglu <[email protected]>
Co-authored-by: Rodrigo <[email protected]>
Co-authored-by: Joseph Lee <[email protected]>
Co-authored-by: Yehonal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfisk underfisk Awaiting requested review from underfisk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing ts-sinon, based on ts-jest functionality
6 participants
@omermorad @underfisk @ali-shabani @MansurAliKoroglu @jclab-joseph @Yehonal