Payments: multi-network support #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `platform` field to `PaymentDetails` and `SchedulePayment`. Supporting multiple networks invalidates the assumption that every driver supports a single payment platform. Therefore, this additional information is needed to be able to make appropriate payment. Implemented validation of payment platforms in PaymentProcessor to secure against cross-network replay attacks (i.e. making payment on testnet and claiming it to be a mainnet payment). Signed-off-by: Adam Wierzbicki <[email protected]>
Wiezzel
force-pushed
the
payment/multi-network
branch
from
43edc1b to
662dcb8
Compare
…agna into payment-status/golemsp
… drivers" This reverts commit 78b664c.
Payment status/yagna/stub
[yagna] new payment status CLI
… into payment-status/golemsp
Payment status/golemsp
Added `platform` field to `VerifyPayment`, `GetTransactionBalance`, and `ValidateAllocation` messages for multi-network support. Signed-off-by: Adam Wierzbicki <[email protected]>
Applied review comments. Signed-off-by: Adam Wierzbicki <[email protected]>
[golemsp] lower default price per hour of computations from 1 to 0.1 GLM
Zksync multi network
Multi-network support in ERC20 driver
Verify zksync transaction hash
Add fund command to zksync driver
Signed-off-by: Adam Wierzbicki <[email protected]>
maaktweluit
approved these changes
Jan 25, 2021
tworec
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
platformfield toPaymentDetailsandSchedulePayment. Supporting multiple networks invalidates the assumption that every driver supports a single payment platform. Therefore, this additional information is needed to be able to make appropriate payment.Implemented validation of payment platforms in PaymentProcessor to secure against cross-network replay attacks (i.e. making payment on testnet and claiming it to be a mainnet payment).