Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enter / exit / transfer commands to CLI #931

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Add enter / exit / transfer commands to CLI #931

merged 4 commits into from
Jan 19, 2021

Conversation

maaktweluit
Copy link
Contributor

Add CLI commands, GSB messages and driver implementation stubs for:

yagna payment enter --driver=zksync --network=rinkeby
yagna payment exit --driver=zksync --network=rinkeby [optional address]
yagna payment transfer —driver=zksync —network=rinkeby [address]

@maaktweluit maaktweluit self-assigned this Jan 18, 2021
@maaktweluit maaktweluit requested a review from a team January 18, 2021 11:02
Copy link

@Wiezzel Wiezzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing amount should be done in CLI, not in driver.

@maaktweluit
Copy link
Contributor Author

@Wiezzel Was unsure about amount, since it will be put into a string when send over GSB anyhow...

Will update it to parse earlier :)

@maaktweluit maaktweluit requested a review from Wiezzel January 18, 2021 11:56
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@pnowosie pnowosie merged commit d4f5401 into master Jan 19, 2021
@maaktweluit maaktweluit deleted the mwu/withdraw branch January 19, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants